Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eval's KEYS and ARGV are now lua tables #208

Merged
merged 1 commit into from
Aug 24, 2018
Merged

eval's KEYS and ARGV are now lua tables #208

merged 1 commit into from
Aug 24, 2018

Conversation

NimrodParasol
Copy link
Contributor

During eval operation, KEYS and ARGV are now passed as Lua tables instead of Python lists.
This allows for iteration over them within the Lua script

This is a fix to the error described in issue 204

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.483% when pulling 26b2738 on NimrodParasol:eval-keys-args-lua-objects into c3c45af on jamesls:master.

bmerry
bmerry approved these changes Aug 24, 2018
View reviewed changes
Copy link
Collaborator

@bmerry bmerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'd missed that this was a separate PR to the other one.

@bmerry bmerry merged commit 90564d0 into jamesls:master Aug 24, 2018
@bmerry bmerry mentioned this pull request Aug 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmerry bmerry bmerry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NimrodParasol @coveralls @bmerry @nimrod-otonomo