Redis operation that returns dict now converted to Lua table when called inside eval operation #209
Conversation
…ries are now passed as lua tables instead of python lists
…o keep consistency with other tests
|
@bmerry I added the key as you asked. but for future reference please notice that as far as I've seen the tests never use the keys that are passed to them but using hard-coded values within the Lua scripts. |
test_fakeredis.py
Outdated
| end | ||
| return result | ||
| """ | ||
| val = self.redis.eval(lua, 0, 'foo') |
There was a problem hiding this comment.
Should be 1, not 0 (number of keys passed).
There was a problem hiding this comment.
You are totally right.
Fixed it.
I agree, that's not ideal, but it's legal. According to the redis docs, "All Redis commands must be analyzed before execution to determine which keys the command will operate on. In order for this to be true for EVAL, keys must be passed explicitly." It doesn't matter to redis whether the Lua code uses KEYS or hard-codes them, as long as the redis server is informed about all keys that might be accessed. |
During eval operation, results of Redis operations returning dictionaries are now passed as Lua tables instead of python lists
This allows for iteration over them within the Lua script.
This is a fix to the error described in issue 204