Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep pace with redis-py for zrevrange method #215

Merged
merged 1 commit into from
Sep 11, 2018
Merged

keep pace with redis-py for zrevrange method #215

merged 1 commit into from
Sep 11, 2018

Conversation

bkda
Copy link
Contributor

@bkda bkda commented Sep 11, 2018

I just tried to use fakeredis to test my code, e.g.

data = redis.zrevrange(cls.KEY.format(challenge_id=challenge_id), start=offset, end=offset + limit,
                                       withscores=True)

And I found type error:

TypeError: zrevrange() got an unexpected keyword argument 'end'

So maybe it's better to keep pace with redis-py on zrevrange method?
Also you can check here

Cheers.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.484% when pulling 310cfb1 on da2018:master into eb2eb27 on jamesls:master.

@bmerry bmerry merged commit b87e885 into jamesls:master Sep 11, 2018
@bmerry
Copy link
Collaborator

bmerry commented Sep 11, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants