Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.7 #222

Merged
merged 3 commits into from
Nov 7, 2018
Merged

Python 3.7 #222

merged 3 commits into from
Nov 7, 2018

Conversation

owenstranathan
Copy link
Contributor

It works out of the box. Only thing is deprecation warnings that are annoying in tests.

Given this:
https://docs.python.org/3/whatsnew/3.7.html#id3

Getting ABCs from collections is depricated in 3.8 so this preemptively fixes that and also get rid of those pesky aforementioned deprecation warnings.

Also adds a Pipfile for those of us who have adopted Pipenv.

@coveralls
Copy link

coveralls commented Nov 6, 2018

Coverage Status

Coverage increased (+0.003%) to 98.155% when pulling fb7b600 on owenstranathan:fix-deprication-warnings into 39a56a6 on jamesls:master.

Copy link
Collaborator

@bmerry bmerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the 3.8 support!

I don't use pipenv myself, and currently I'm the only maintainer (in very limited spare time). Would you sign up to maintain the Pipfile? It shouldn't be much work since very little is happening on fakeredis, but I'd rather not add something that is immediately unmaintained.

fakeredis.py Outdated Show resolved Hide resolved
@owenstranathan
Copy link
Contributor Author

@bmerry Added Explicit except ImportError. Also I would be happy to maintain the Pipfile.

@bmerry
Copy link
Collaborator

bmerry commented Nov 7, 2018

Great. Travis failed for some reason, but it doesn't seem like it's related to your change at all so I'm rerunning it. Assuming that passes I'll merge.

@jamesls, if you're happy could you give @owenstranathan write access? It seems I don't have permission.

@bmerry
Copy link
Collaborator

bmerry commented Nov 7, 2018

I suspect the Python 3.7 problem is because Travis has switched to redis 5.0 (but presumably only on xenial, not trusty). Master is also failing. So I'm going to merge anyway.

@bmerry bmerry merged commit 16ee5eb into jamesls:master Nov 7, 2018
@bmerry
Copy link
Collaborator

bmerry commented Jan 7, 2019

@owenstranathan I've got a branch called rewrite which has new and updated dependencies. Could you contribute an updated Pipfile for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants