Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix implementation of ZSCAN #252

Merged
merged 1 commit into from
Aug 26, 2019
Merged

Fix implementation of ZSCAN #252

merged 1 commit into from
Aug 26, 2019

Conversation

bmerry
Copy link
Collaborator

@bmerry bmerry commented Aug 26, 2019

It still lacks unit tests. See #251.

@bmerry bmerry self-assigned this Aug 26, 2019
@bmerry
Copy link
Collaborator Author

bmerry commented Aug 26, 2019

@abdolsamad give this a try. I'll need to add a unit test before I merge, but it looks like it works for the case you were trying.

@coveralls
Copy link

coveralls commented Aug 26, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 94.143% when pulling 9591657 on fix-zscan into 28a7591 on master.

@bmerry bmerry marked this pull request as ready for review August 26, 2019 09:08
@bmerry bmerry merged commit edbea07 into master Aug 26, 2019
@bmerry bmerry deleted the fix-zscan branch August 26, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bmerry bmerry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bmerry @coveralls