Add other inputs for redis connection #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 similar comments
bmerry
reviewed
Nov 24, 2019
fakeredis/_server.py
Outdated
| encoding='utf-8', encoding_errors='strict', | ||
| decode_responses=False, | ||
| health_check_interval=0): | ||
| self.pid = os.getpid() | ||
| self.db = db | ||
| self.password = password | ||
| # Allow socket attributes to be passed in and saved even if they aren't used |
There was a problem hiding this comment.
Suggested change
| # Allow socket attributes to be passed in and saved even if they aren't used | |
| # Allow socket attributes to be passed in and saved even if they aren't used |
| @@ -2490,12 +2490,22 @@ class FakeConnection(redis.Connection): | |||
| description_format = "FakeConnection<db=%(db)s>" | |||
|
|
|||
| def __init__(self, server, db=0, password=None, | |||
| socket_timeout=None, socket_connect_timeout=None, | |||
| socket_keepalive=False, socket_keepalive_options=None, | |||
| socket_type=0, retry_on_timeout=False, | |||
There was a problem hiding this comment.
Are these in the same position/order that the redis __init__ takes them?
There was a problem hiding this comment.
Yeah at least as it is currently on master. I had forgotten a couple and just added them. Sorry.
| self.socket_timeout = socket_timeout | ||
| self.socket_connect_timeout = socket_connect_timeout or socket_timeout | ||
| self.socket_keepalive = socket_keepalive | ||
| self.socket_keepalive_options = socket_keepalive_options or {} |
There was a problem hiding this comment.
I take it this is equivalent to what real redis is setting on self?
There was a problem hiding this comment.
Yeah this was taken directly from redis-py.
* Fix typo * Add remaining input arguments and make sure order matches redis-py * Add test to hit or statements and keep up test coverage * Add input argument to the _DummyParser to match what is in redis-py * Remove retry_on_timeout override
|
Thanks, I'm going to merge. Don't worry about coveralls - it was also claiming a reduction in coverage on another PR that only touched the README, so I don't believe in it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #255