Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of async_generator from tests #308

Merged
merged 2 commits into from
Sep 8, 2021
Merged

Conversation

bmerry
Copy link
Collaborator

@bmerry bmerry commented Sep 6, 2021

pytest-asyncio 0.15 no longer supports async-generator, and it's not
needed in Python 3.6+ (which is all that gets tested).

Closes #307.

pytest-asyncio 0.15 no longer supports async-generator, and it's not
needed in Python 3.6+ (which is all that gets tested).

Closes #307.
@bmerry
Copy link
Collaborator Author

bmerry commented Sep 6, 2021

For some reason the coverage run is getting stuck every time in CI. I'm trying to debug that on a separate branch now.

@coveralls
Copy link

coveralls commented Sep 6, 2021

Coverage Status

Coverage decreased (-0.04%) to 93.509% when pulling bb9a44f on no-async-generator into 2d267e7 on master.

To try to get more feedback on where it's getting stuck in CI.
@bmerry
Copy link
Collaborator Author

bmerry commented Sep 6, 2021

For some reason the coverage run is getting stuck every time in CI. I'm trying to debug that on a separate branch now.

For whatever reason, running the tests with pytest -v has made the problem disappear. That's something I wanted to do anyway (so that when things do go wrong there is more feedback).

I'm not worried about the decrease in coverage - I Think that's likely to just be because I removed a few lines of code from the test.

@bmerry bmerry merged commit 9725bd2 into master Sep 8, 2021
@bmerry bmerry deleted the no-async-generator branch September 8, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.6.0: pytest is failing
3 participants