Allow Propshaft assets to use fallbacks #140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're longtime
inline_svg
users, and we've really enjoyed your work on this gem. Thank you!When running Rails 7 using Propshaft, when an asset is not found, the asset path resolver returns nil, raising an exception, even when
fallback:
is provided. This commit introduces a nil check around the asset path finder's return value, a lot like the one inStaticAssetFinder
.The higher-level
FindsAssetPaths
spec never calls down into thePropshaftAssetFinder
itself, so this commit also introduces a test suite around thePropshaftAssetFinder
.