Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Propshaft assets to use fallbacks #140

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Allow Propshaft assets to use fallbacks #140

merged 1 commit into from
Jul 18, 2022

Conversation

ohrite
Copy link
Contributor

@ohrite ohrite commented Jul 17, 2022

We're longtime inline_svg users, and we've really enjoyed your work on this gem. Thank you!

When running Rails 7 using Propshaft, when an asset is not found, the asset path resolver returns nil, raising an exception, even whenfallback: is provided. This commit introduces a nil check around the asset path finder's return value, a lot like the one in StaticAssetFinder.

The higher-level FindsAssetPaths spec never calls down into the PropshaftAssetFinder itself, so this commit also introduces a test suite around the PropshaftAssetFinder.

Copy link
Owner

@jamesmartin jamesmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, much appreciated! ✨

@jamesmartin jamesmartin merged commit c220609 into jamesmartin:main Jul 18, 2022
@ohrite ohrite deleted the allow-propshaft-fallbacks branch July 19, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants