Run GitHub Actions on PRs #159
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagliala
force-pushed
the
chore/run-actions-on-prs
branch
from
911bbdb
to
03316df
Compare
tagliala
force-pushed
the
chore/run-actions-on-prs
branch
9 times, most recently
from
27eb03d
to
9b78de4
Compare
|
I'm facing some issues related to the usage of an old version of webpacker which still uses node-sass, and Python 2.7 is not available anymore. I guess that https://github.com/jamesmartin/inline_svg_test_app/tree/rails6-webpacker needs an updated, but then we should use webpacker 5.x |
Shakapacker is the official, actively maintained successor to Webpacker. Shakapacker v7 changed the spelling of `Webpacker` to `Shakapacker` in the entire project, but still provided backward compatibility for `Webpacker` spelling. v8 dropped the deprecated spelling This commit also: - Checks if `Shakapacker` is defined; if not, it falls back on `Webpacker`. - Uses the scope resolution operator to resolve at top-level scope - Checks `protocol` instead of `https?` because the former is available from Webpacker 3 and the latter is not available anymore in Shakapacker >= 8 Refs: - shakacode/shakapacker#414 - shakacode/shakapacker#429 - shakacode/shakapacker#486 Close jamesmartin#156
tagliala
force-pushed
the
chore/run-actions-on-prs
branch
3 times, most recently
from
f81547f
to
cabcf4c
Compare
|
Thanks for opening this PR. New branch created in the |
Also: - Set explicit permissions to read for better security. Workflows run with extended set of permissions by default. By specifying any permission explicitly, all others are set to none. - Update actions to prevent deprecation warning messages - Remove redundant `gem install bundler` (bundler is already available after setup-ruby action) Ref: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions
tagliala
force-pushed
the
chore/run-actions-on-prs
branch
from
cabcf4c
to
88b6f0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've noticed that PRs do not run actions, so they can introduce issues that will only discovered when merged to master
--
Also:
Ref: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions
Blocked by
rails7-shakapackerbased onrails6-webpackerinline_svg_test_app#23