fix: Wrap headers with AxiosHeaders to prevent incorrect type being passed

[danielcooperxyz]

We have experienced issues with the latest version of axios (1.6.3) passing through bad header objects which are not of the correct type which causes the below error from the transformRequest method in axios.

ERROR TypeError: t.getContentType is not a function at Oe.transformRequest

This PR includes a new line that will wrap the header object each time regardless of what is passed, to enforce that the correct type is then passed to the transformRequest transformer function.

Fixes #1250

[snoblenet]

hi @danielcooperxyz -- thanks for these changes -- it looks like a build is expected?

[snoblenet]

and in the mean time, how are you including this in your package.json?

[loukmane-issa]

and in the mean time, how are you including this in your package.json?

Did you get any chance at all with this? I'm experiencing the same issue and it would be a shame to have to write my own :(

[BourgoisMickael]

This won't fix the bug everywhere, you should fix the actual headers when they are set at line 170:

https://github.com/jamesmbourne/aws4-axios/pull/1248/files#diff-bc2f1f907be8c49520a585dda7f0c100645e31e9bedf3828c3850fdf8389e619R170

config.headers = signingOptions.headers as AxiosHeaders;

This should not be casted but should be a real AxiosHeaders instance. Otherwise this lib will still break axios for every other uses outside this lib.

[BourgoisMickael]

If a maintainer could look into this quickly, it would be nice. It's just a oneliner.

Here is a workaround in the meantime:

axios.interceptors.request.use(async req => {
    const signedReq = await interceptor(req);
    signedReq.headers = new axios.AxiosHeaders(signedReq.headers);
    return signedReq;
});

[jamesmbourne]

Hey @danielcooperxyz, thanks for putting this fix in. I'll try and get this merged & released today 🤞

[github-actions]

🎉 This PR is included in version 3.3.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀