Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(top-app-bar): Fix wrong className for TopAppBarAdjust #635

Merged
merged 1 commit into from Jun 11, 2020

Conversation

33577
Copy link
Contributor

@33577 33577 commented May 18, 2020

Hi,
I want to resolve this issue, #634.
Since media query, className mdc-top-app-bar--fixed-adjust has higher priority than .mdc-top-app-bar--dense-fixed-adjust in <TopAppBarFixedAdjust dense />.

So, I want to add className mdc-top-app-bar--fixed-adjust when all props (dense, denseProminent, prominent, short) are undefined or false.
Since the only css property that mdc-top-app-bar--fixed-adjust or .mdc-top-app-bar--dense-fixed-adjust manipulates is padding-top, I think this PR makes sense.
But, I know this PR makes the className mdc-top-app-bar--fixed-adjust loose its role as default className for <TopAppBarFixedAdjust />
In addition, I'm worried since this line need update if another property of TopAppBarFixedAdjust is created newly.

If you have more appropriate idea, please let me know.

Thanks!!

image

(In <TopAppBarFixedAdjust dense />, I want 48px padding-top but 56px is activated)

resolve: #634

@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #635 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #635   +/-   ##
=======================================
  Coverage   83.05%   83.06%           
=======================================
  Files          99       99           
  Lines        3223     3224    +1     
  Branches      741      744    +3     
=======================================
+ Hits         2677     2678    +1     
  Misses        541      541           
  Partials        5        5           
Impacted Files Coverage Δ
src/top-app-bar/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b184d0c...c4ff766. Read the comment docs.

@jamesmfriedman jamesmfriedman merged commit 8c87e80 into rmwc:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong className for TopAppBarFixedAdjust
2 participants