fix(top-app-bar): Fix wrong className for TopAppBarAdjust #635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I want to resolve this issue, #634.
Since media query, className
mdc-top-app-bar--fixed-adjust
has higher priority than.mdc-top-app-bar--dense-fixed-adjust
in<TopAppBarFixedAdjust dense />
.So, I want to add className
mdc-top-app-bar--fixed-adjust
when all props (dense, denseProminent, prominent, short) are undefined or false.Since the only css property that
mdc-top-app-bar--fixed-adjust
or.mdc-top-app-bar--dense-fixed-adjust
manipulates ispadding-top
, I think this PR makes sense.But, I know this PR makes the className
mdc-top-app-bar--fixed-adjust
loose its role as default className for<TopAppBarFixedAdjust />
In addition, I'm worried since this line need update if another property of
TopAppBarFixedAdjust
is created newly.If you have more appropriate idea, please let me know.
Thanks!!
(In
<TopAppBarFixedAdjust dense />
, I want 48px padding-top but 56px is activated)resolve: #634