Update openstack provider with multiattach functionality

This update adds multiattach functionality for volumes (Issue terraform-provider-openstack#432)
jamesmmccarthy · Sep 26, 2018 · 191230c · 191230c
1 parent 2e81bbb
commit 191230c
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 0 deletions.
diff --git a/openstack/resource_openstack_blockstorage_volume_v3.go b/openstack/resource_openstack_blockstorage_volume_v3.go
@@ -99,6 +99,10 @@ func resourceBlockStorageVolumeV3() *schema.Resource {
 				Optional: true,
 				ForceNew: true,
 			},
+			"multiattach": &schema.Schema{
+				Type:     schema.TypeBool,
+				Optional: true,
+			},
 			"attachment": &schema.Schema{
 				Type:     schema.TypeSet,
 				Computed: true,
@@ -143,6 +147,7 @@ func resourceBlockStorageVolumeV3Create(d *schema.ResourceData, meta interface{}
 		SourceReplica:      d.Get("source_replica").(string),
 		SourceVolID:        d.Get("source_vol_id").(string),
 		VolumeType:         d.Get("volume_type").(string),
+		Multiattach:        d.Get("multiattach").(bool),
 	}
 
 	log.Printf("[DEBUG] Create Options: %#v", createOpts)

diff --git a/openstack/resource_openstack_blockstorage_volume_v3_test.go b/openstack/resource_openstack_blockstorage_volume_v3_test.go
@@ -89,6 +89,26 @@ func TestAccBlockStorageV3Volume_image(t *testing.T) {
 	})
 }
 
+func TestAccBlockStorageV3Volume_image_multiattach(t *testing.T) {
+	var volume volumes.Volume
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
+		CheckDestroy: testAccCheckBlockStorageV3VolumeDestroy,
+		Steps: []resource.TestStep{
+			resource.TestStep{
+				Config: testAccBlockStorageV3Volume_image_multiattach,
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckBlockStorageV3VolumeExists("openstack_blockstorage_volume_v3.volume_1", &volume),
+					resource.TestCheckResourceAttr(
+						"openstack_blockstorage_volume_v3.volume_1", "name", "volume_1"),
+				),
+			},
+		},
+	})
+}
+
 func TestAccBlockStorageV3Volume_timeout(t *testing.T) {
 	var volume volumes.Volume
 
@@ -273,6 +293,15 @@ resource "openstack_blockstorage_volume_v3" "volume_1" {
 }
 `, OS_IMAGE_ID)
 
+var testAccBlockStorageV3Volume_image_multiattach = fmt.Sprintf(`
+resource "openstack_blockstorage_volume_v3" "volume_1" {
+  name = "volume_1"
+  size = 5
+  image_id = "%s"
+  multiattach = true
+}
+`, OS_IMAGE_ID)
+
 const testAccBlockStorageV3Volume_timeout = `
 resource "openstack_blockstorage_volume_v3" "volume_1" {
   name = "volume_1"