Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PurchaseState.PaymentPending and PurchaseState.Pending #394

Closed
MichalTelus opened this issue Jun 24, 2021 · 1 comment
Closed

PurchaseState.PaymentPending and PurchaseState.Pending #394

MichalTelus opened this issue Jun 24, 2021 · 1 comment

Comments

@MichalTelus
Copy link

Hi,

I like this plugin, it's super useful, however I find out one thing that is confusing.
In enum PurchaseState there are two pending states: PurchaseState.PaymentPending and PurchaseState.Pending. As I understood the PurchaseState.Pending is obsolete or not used at all.

It's a rather small thing so maybe you could remove it, add obsolete parameter or add some explanation when we should use it?

@jamesmontemagno
Copy link
Owner

I will add the obsolete flag. I am not sure why it was ever added, but yeah i only ever return PaymentPending currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants