Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Don't call SetOffer for one-time purchases #602

Closed
overzealus opened this issue May 8, 2024 · 1 comment · Fixed by #603
Closed

[Android] Don't call SetOffer for one-time purchases #602

overzealus opened this issue May 8, 2024 · 1 comment · Fixed by #603

Comments

@overzealus
Copy link

If you are creating an issue for a BUG please fill out this information. If you are asking a question or requesting a feature you can delete the sections below.

Failure to fill out this information will result in this issue being closed. If you post a full stack trace in a bug it will be closed, please post it to http://gist.github.com and then post the link here.

Bug Information

Recently Google Play started to send messages of incorrect usage of billing library.
In this email they say that if you call setOfferToken with "" value, you should remove this calls.
In https://developer.android.com/google/play/billing/integrate#launch Google notice that
For One-time product, "setOfferToken" method shouldn't be called.
For subscriptions, to get an offer token, call ProductDetails.subscriptionOfferDetails() for a list of offers that are available to the user

Version Number of Plugin: 7.1.0
Device Tested On: Android with Google Play
Simulator Tested On: no
Version of VS: 17.9.3
Version of Xamarin: 17.9.0.138
Versions of other things you are using:

Steps to reproduce the Behavior

Expected Behavior

Don't call setOfferToken if offer Token is not provided by calling method.

Actual Behavior

setOfferToken is called -> Google sends warnings

Code snippet

Screenshotst

@overzealus
Copy link
Author

Can you tell when updated nuget package would be available?

jamesmontemagno added a commit that referenced this issue May 11, 2024
Updated methods and packages for setoffertoken
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant