FIXED: Always call OnPurchaseSuccess if defined for out of band purchases #204
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm just loading the pre-release binaries from the appveyor build into our app, and I will ship a beta version and report back with the results |
jamesmontemagno
approved these changes
Jan 22, 2019
|
I am sure it wont hurt at all. |
Hi @mgoodfellow how has your testing gone so far for out-of-band? Do you have a technique for causing an out-of-band for testing, we haven't been able to replicate this ourselves, but our users are seeing it. |
|
@devology-rob So far, we have had no reports of these failed purchases with our users 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a moment to fill out the following:
Fixes #176 .
Changes Proposed in this pull request:
OnPurchaseSuccessif defined, allowing this handler to process out of band purchases (such as after changing payment method)Credit: @kjoiner