Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start implementation of new billing #295

Merged
merged 18 commits into from Dec 31, 2020

Conversation

jamesmontemagno
Copy link
Owner

Please take a moment to fill out the following:

Fixes # .

Changes Proposed in this pull request:

@Dexus
Copy link

Dexus commented Jul 21, 2020

Hi @jamesmontemagno you should be sure to use the latest Goole Billing API (v3.0) if not your app will rejected and not published anymore also your app will removed from the playstore. So my question now is Xamarin.Android.Google.BillingClient 3.0 equivalent to API 3.0?

Best regards, Josef

@jamesmontemagno
Copy link
Owner Author

yeah, we already updated to 3.0.

Also, that is different that is for the server, not in the app. it is confusing.

@Dexus
Copy link

Dexus commented Jul 22, 2020

yeah, we already updated to 3.0.

Also, that is different that is for the server, not in the app. it is confusing.

Thanks for the info.

@dmariogatto
Copy link
Contributor

I noticed that the signature of GetPurchasesAsync has changed to no longer accept an instance of IInAppBillingVerifyPurchase. Is there a reason restoring previous purchases no longer requires validation?

@jamesmontemagno
Copy link
Owner Author

jamesmontemagno commented Jul 28, 2020

It exists,

Task<IEnumerable<InAppBillingPurchase>> GetPurchasesAsync(ItemType itemType);

It no longer requires verification as it wasn't adding value at all in the implementation. You can still verify and just call it yourself. I don't want to be in control of your verification process.

@jamesmontemagno jamesmontemagno merged commit dec5ede into master Dec 31, 2020
@jamesmontemagno jamesmontemagno deleted the feature/new-android-billing branch April 12, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants