-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't auto finish transactions #444
Conversation
Give ability to turn it on though if we want to for back compat for non-consumeables.
It's been a while since I've had this top of mind, so forgive me if the answer is obvious, but shouldn't we just finish all non-consumable transactions automatically, and if the product is consumable on apple, then Finish the transaction when ConsumePurchaseAsync is called, like in android? Or am I missing something? |
Yes, I would have to know if your transaction is consumable or not... else maybe I pass in a flag... let me see here |
The other ting is that I also Finish all transactions on restore as well as that was a recommended pattern... |
Alright... so check the code now... I introduced a new ItemType of Consumable. If it is consumable then we don't autofinish the transaction. Now on restore it is tricky. I am goign to make the getpurchases take in a list of ids not to finish. so a bit of work, but I think smoother |
@edgiardina now finished with the implementation. let me know what you think there. I also updated documentation |
Give ability to turn it on though if we want to for back compat for non-consumeables.
Please take a moment to fill out the following:
Fixes #414.
Changes Proposed in this pull request: