Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safer PaymentObserver unsubscribe #601

Closed
wants to merge 2 commits into from
Closed

Safer PaymentObserver unsubscribe #601

wants to merge 2 commits into from

Commits on May 8, 2024

  1. Safer PaymentObserver unsubscribe 

    This ensures no matter what happens with the RestoreCompletedTransactions call, or the callback for the payment observer, that we always unsubscribe from the payment observer's event.
    @Redth
    Redth committed May 8, 2024
    Configuration menu
    Copy the full SHA
    f6e6230 View commit details
    Browse the repository at this point in the history

  2. Move the unsubscribe into the finally block 

    This way if for some reason the product request fails, or the add payment fails, the observer's event will still be unsubscribed.
    @Redth
    Redth committed May 8, 2024
    Configuration menu
    Copy the full SHA
    e4ca45d View commit details
    Browse the repository at this point in the history