DateTime.ToString() and neutral calendar

[FrancoisM]

That line: should be called with a neutral calendar as for some of my users it throw an exception as per that discussion.

[jamesmontemagno]

Are you sure it actually throws an exception? As I pass in an actual value for the format. Which is different then what they are doing in that thread.

[FrancoisM]

Actual HockeyApp Crash Trace:

 [DateTimeFormatInfo set_Calendar(System.Globalization.Calendar value)]
System.ArgumentOutOfRangeException: Not a valid calendar for the given culture.

Parameter name: value
System.Globalization.DateTimeFormatInfo.set_Calendar(Calendar value)
System.Globalization.DateTimeFormatInfo.DateTimeFormatInfo(CultureData cultureData, Calendar cal)
System.Globalization.CultureInfo.get_DateTimeFormat()
System.Globalization.CultureInfo.GetFormat(Type formatType)
System.Globalization.DateTimeFormatInfo.get_CurrentInfo()
System.DateTime.ToString(string format)
Plugin.Media.MediaPickerDelegate.GetOutputPath(string type, string path, string name)
Plugin.Media.MediaPickerDelegate.<GetPictureMediaFile>d__24.MoveNext()
Plugin.Media.MediaPickerDelegate.<FinishedPickingMedia>d__9.MoveNext()
Social.iOS.Application.Main(string[] args)

[jamesmontemagno]

I'll integrate this in, however it should be in bugzilla as it is clearly a mono bug

[FrancoisM]

I don't know which calendar caused the issue. I don't know how to report crashes with userid on HockeyApp (but that's another issue) in order to find out.
I'll compile my iOS project with Properties>iOSBuild>Advanced>Internalization>all boxes checked and hopefully the issue will disapear (I read some calendars where not linked otherwise).
But you could make your ToString() using invariant culture as it doesn't matter in the case where you call it.

[jamesmontemagno]

Cool, thanks for info.

Will do this:

            var now = DateTime.Now;
            string timestamp = $"{now.Year}{now.Month}{now.Day}_{now.Hour}{now.Minute}{now.Second}";

[FrancoisM]

You already done it! Great!
But why not just ?

DateTime.Now.ToString("yyyMMdd_HHmmss", CultureInfo.InvariantCulture)

[jamesmontemagno]

Maybe... do we know for sure it would work?

[FrancoisM]

For sure? No. It should though. UnitTest?

[jamesmontemagno]

teheh
well pushing it out