Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write attributes #581

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Write attributes #581

wants to merge 13 commits into from

Conversation

jamesmudd
Copy link
Owner

No description provided.

@jamesmudd jamesmudd changed the title vvccccrdrcerjfctuhkdnfhdjennghdncubghvdrhdccWrite attributes Write attributes Jun 5, 2024
@cfoushee
Copy link

Looks like its close to being done. Any plans on releasing a new version that includes this soon?

@jamesmudd
Copy link
Owner Author

I would like to. It is close, writing and reading attributes work in jhdf. H5dump also reads them correctly, but for some reason hdfview doesn't. I would like to understand this issue before releasing this.

@Apollo3zehn
Copy link

@jamesmudd
Copy link
Owner Author

@Apollo3zehn Thanks! I think it might well be related. I will have a play. Notice there is not much movement on this for a while, do you think it should be fixed in HDFView or is writing a fake Attribute Info Message a reasonable solution?

@Apollo3zehn
Copy link

I think for now the extra message should be created, I am not counting on a quick solution in HDFView.

Copy link

sonarcloud bot commented Jun 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
77.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants