Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul of depot/replace dialog #561

Merged

Conversation

FIX: Vehicle list is not updated correctly after action
TODO: Restore the convoy capacity
TODO: Restore the list of selectable livery schemes
CODE: Separate into files for code sharing with future line list dialog
…te button but a button that opens a separate window (if there is a suitable image)
@MatthewForrester
Copy link

MatthewForrester commented Jul 19, 2022

Ranran, as I have no access to the forum at the moment, I will report the results of my testing here.

Thank you so much for this patch!

Bugs Fixed 🎆
The Depot and Replace Dialogs have been buggy for a long time. You have repaired them, including the Details button that you created. We also have the correct display of engine type again. Bug-fixing is maybe boring but I really appreciate it.

So Many New Features! ✨
You have added new capabilities to the UI. I really appreciate your contributions here. In particular, the new sort options (especially axle load, maintenance and range) will be a great improvement for players. The colour bar legend is a great help for new players. The ability to name depots will make it much easier to use the Depot List. And the free text search makes it much easier to find carriages from the same company. Thank you.

Liveries
You said in your forum post that "The vehicle's livery schemes display has been removed. It has no space to display. Check it out in convoy detail." I understand space in the dialog is limited. However, in my opinion displaying livery in theDetail Window is not a good solution because players cannot see which liveries are possible for each vehicle. Look at this example:
image
This depot has 29 liveries available. Most of them are only available for 2 or 3 vehicles. But to see the possibilities for one vehicle, I have to open Livery scheme → choose livery → open Details →switch to Specification tab = 4x28 = 56 clicks. Now my mouse hand hurts. 😫

Alsoy, the Livery Scheme drop-down does not change the livery displayed in the top or bottom parts of the Depot/Replace Dialogs. So we cannot preview the livery. This is a loss of function. Could you please restore the livery preview function and the livery information?

Way Constraints
The bottom part of the window tells us if a powered vehicle has certain way constraints. For example, this locomotive has the permissive way constraint AC Overhead Catenary:
image
However, some locomotives can use all electric Track ways, in which case there is no permissive way constraint shown. I think the previous Depot window had MUST USE: and MAY USE: labels for prohibitive and permissive way contraints. I think it would be helpful to new players if these labels were restored to explain the way constraint information.

Future Feature: Vehicle Use Descriptions
There has been a discussion on the forum about adding more information to help users choose the correct vehicle. Also Leartin said on Discord:
"Isn't it strange that in a transportation game, you can have quite the elaborate descriptions of pretty much all kinds of things - buildings, factories, roads, randomly sprinkled ponds in the landscape... but not for vehicles?"
In my opinion, this would be a very helpful new feature and I think that you should reserve space for it. My suggestion: the Author information can be reserved as space for this feature. When the new feature is ready, the Author information can be moved to the Details window.

Mystery Ship Vehicles
If I select "Show All" in a ship depot, I get "mystery vehicles" that cannot be selected:
image
I guess that they are holds (though they are not obligatory mail holds). This is a very small problem and probably not a new problem either.

Again, thank you for an excellent patch. There are some small problems but it will be a great improvement.

(This post is released into the public domain for copying to the forum)

@MatthewForrester
Copy link

(Request) Replace Default
Sorry, a feature extension request that I forgot above. In the Replace Dialog, the default option is Only this convoy:
image
I would prefer Replace all in line as default, because I use this option much more. Perhaps default is just chosen by English alphabetical order here? But if you can select a default, that would be helpful please. Thank you for considering this request.

@jamespetts jamespetts merged commit ae905a1 into jamespetts:master Aug 7, 2022
@Ranran-the-JuicyPork Ranran-the-JuicyPork deleted the 2207-depot-veh-sorting branch August 19, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants