Fab workarounds #603
Merged
Fab workarounds #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If factory_enforce_demand is false, don't create staff shortages. (This allows workarounds for problems with the commuter system.) If factory_enforce_demand is true, cause a shop with no staff to be "out of stock" even if it has only one input. (This was a bug.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-enables "factory_enforce_demand", which was a nonfunctional option which was not checked in the current codebase. Default remains 1. If set to 0, staff shortages do not happen. This allows for turning off staff shortages without directly messing with the minimum staffing percentages, which I find useful both for playing (when there are staff shortage issues) and for debugging.
If factory_enforce_demand = 1 (the default), then this also fixes a bug where a consumer industry with a single input could sell stock even with no staff because the previous code bypassed the staff shortage check; the staff shortage check is now first.
I will try to track down the root cause of the staff shortage bugs later but this is, at any rate, an improvement.