More tests, and a bug fix

tests/unit/scheduler/test_server.py

@@ -10,6 +10,9 @@
 from transiter.scheduler import server
 from transiter.services import feedservice
 
+SYSTEM_ID = "1"
+FEED_ID = "2"
+
 
 @pytest.fixture
 def scheduler(monkeypatch):
@@ -28,10 +31,6 @@ def test_transiter_registry(scheduler):
     )
 
 
-SYSTEM_ID = "1"
-FEED_ID = "2"
-
-
 @pytest.mark.parametrize(
     "existing_feeds,new_feeds,job_added,job_removed",
     [
@@ -120,3 +119,51 @@ def test_initialize_registry(
 
     if expect_exit_call:
         exit_mock.assert_called_once()
+
+
+def test_schedule__json():
+    class DummyFooSchedule(server.Schedule):
+        pass
+
+    dummy_schedule = DummyFooSchedule()
+    dummy_schedule._black = "beans"
+
+    expected = {"type": "DUMMY_FOO", "parameters": {"black": "beans"}}
+
+    assert expected == dummy_schedule.json()
+
+
+def test_schedule__abstract_methods():
+    schedule = server.Schedule()
+
+    with pytest.raises(NotImplementedError):
+        schedule.job_kwargs()
+
+
+def test_task__json():
+    class DummyBarTask(server.Task):
+        pass
+
+    task = DummyBarTask()
+    task._mint = "mundo"
+
+    expected = {"type": "DUMMY_BAR", "parameters": {"mint": "mundo"}, "schedule": None}
+
+    assert expected == task.json()
+
+
+def test_task__abstract_methods():
+    task = server.Task()
+
+    with pytest.raises(NotImplementedError):
+        task.run()
+
+
+def test_registry__abstract_methods():
+    registry = server.Registry()
+
+    with pytest.raises(NotImplementedError):
+        registry.all_tasks()
+
+    with pytest.raises(NotImplementedError):
+        registry.refresh()

transiter/scheduler/server.py

@@ -169,10 +169,10 @@ def initialize(self):
             break
 
     def refresh(self):
-        return NotImplementedError
+        raise NotImplementedError
 
     def all_tasks(self):
-        return NotImplementedError
+        raise NotImplementedError
 
 
 class FeedAutoUpdateRegistry(Registry):