Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test cases. #1

Merged
merged 3 commits into from
Dec 23, 2014
Merged

Fix test cases. #1

merged 3 commits into from
Dec 23, 2014

Commits on Dec 23, 2014

  1. Fix test cases. 

    First, regions have a pointer to its el. No need for a lookup.
Second, I'm detaching all contents before running the replaces.
Third, never replace top view's el, just modify.
    @jridgewell
    jridgewell committed Dec 23, 2014
    Configuration menu
    Copy the full SHA
    5c502e4 View commit details
    Browse the repository at this point in the history

  2. Use cloning. Sorry, screwed that up.

    @jridgewell
    jridgewell committed Dec 23, 2014
    Configuration menu
    Copy the full SHA
    173f0ad View commit details
    Browse the repository at this point in the history

  3. Add Test 4. 

    It uses a placeholder, so we don't have to detach each child node, just
the parent.
    @jridgewell
    jridgewell committed Dec 23, 2014
    Configuration menu
    Copy the full SHA
    4fa5153 View commit details
    Browse the repository at this point in the history