Test signal reuse. Add AbortSignal polyfill. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Hey man, no need to apologize. Do whatever you need to do. I really appreciate you putting the time to contribute ✌️ |
joaovieira
force-pushed
the
abort-polyfill
branch
from
7ddf99b
to
bab0f3d
Compare
Signed-off-by: João Vieira <joaoguerravieira@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test for reusing the same signal to cancel multiple fetch requests (e.g. https://developers.google.com/web/updates/2017/09/abortable-fetch#one_signal_many_fetches)
With that I noticed we needed a better polyfill to handle multiple event listeners, so I added an AbortSignal polyfill (with
EventTarget). It's on a separate file so it can be swapped with any other implementation. I'm keen on fixing mo/abortcontroller-polyfill#11 and use that instead when ready.(Sorry, I know I could've pushed to your branch directly, but had already a big chunk of WIP on mine)