Continue writing tests

src/focus-node.tsx

@@ -177,7 +177,8 @@ export function FocusNode(
   );
 
   const [nodeId] = useState(() => {
-    const nonStringFocusId = typeof focusId !== 'string';
+    const nonStringFocusId =
+      typeof focusId !== 'string' && focusId !== undefined;
     const reservedFocusId = focusId === 'root';
     const invalidNodeId = nonStringFocusId || reservedFocusId;
 

src/hooks/internal/use-on-change.ts

@@ -1,6 +1,5 @@
 import { useEffect } from 'react';
 import usePrevious from './use-previous';
-import { warning } from '../../utils/warning';
 
 type ComparatorFn<Value> = (a: Value, b: Value | undefined) => boolean;
 

src/tests/focus-trap.test.js

@@ -0,0 +1,28 @@
+import React from 'react';
+import '@testing-library/jest-dom';
+import { render, fireEvent, screen } from '@testing-library/react';
+import { FocusRoot, FocusNode, useFocusStoreDangerously } from '../index';
+import { warning } from '../utils/warning';
+
+describe('Focus Traps', () => {
+  it('warns when restoreTrapFocusHierarchy is passed to a non-trap', () => {
+    function TestComponent() {
+      return (
+        <FocusNode restoreTrapFocusHierarchy>
+          <FocusNode>
+            <FocusNode />
+          </FocusNode>
+        </FocusNode>
+      );
+    }
+
+    render(
+      <FocusRoot>
+        <TestComponent />
+      </FocusRoot>
+    );
+
+    expect(warning).toHaveBeenCalledTimes(1);
+    expect(warning.mock.calls[0][1]).toEqual('RESTORE_TRAP_FOCUS_WITHOUT_TRAP');
+  });
+});

src/tests/grids.test.js

@@ -30,6 +30,27 @@ describe('Grids', () => {
     expect(warning.mock.calls[0][1]).toEqual('ORIENTATION_ON_GRID');
   });
 
+  it('warns when onGridMove is passed to a non-grid', () => {
+    function TestComponent() {
+      return (
+        <FocusNode onGridMove={() => {}}>
+          <FocusNode>
+            <FocusNode />
+          </FocusNode>
+        </FocusNode>
+      );
+    }
+
+    render(
+      <FocusRoot>
+        <TestComponent />
+      </FocusRoot>
+    );
+
+    expect(warning).toHaveBeenCalledTimes(1);
+    expect(warning.mock.calls[0][1]).toEqual('GRID_MOVE_NOT_ON_GRID');
+  });
+
   it('warns when onMove is passed', () => {
     function TestComponent() {
       return (