Deleting a resource will not delete it from the store

Previously, it would be set to null
jamesplease · Mar 15, 2018 · c1e3013 · c1e3013
1 parent 72d5ba2
commit c1e3013
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 28 deletions.
diff --git a/packages/redux-resource/src/request-statuses-plugin/delete.js b/packages/redux-resource/src/request-statuses-plugin/delete.js
@@ -175,7 +175,7 @@ function delSucceed(state, action, { initialResourceMeta }) {
   let newResources = Object.assign({}, state.resources);
   if (hasIds) {
     idList.forEach(id => {
-      newResources[id] = null;
+      delete newResources[id];
     });
   }
 

diff --git a/packages/redux-resource/src/update-resources-plugin/index.js b/packages/redux-resource/src/update-resources-plugin/index.js
@@ -182,7 +182,7 @@ export default (resourceType, { initialResourceMeta }) => (state, action) => {
     let newResources = Object.assign({}, state.resources);
     if (hasIds) {
       idList.forEach(id => {
-        newResources[id] = null;
+        delete newResources[id];
       });
     }
 

diff --git a/packages/redux-resource/test/unit/reducers/delete-resources.js b/packages/redux-resource/test/unit/reducers/delete-resources.js
@@ -166,10 +166,8 @@ describe('reducers: DELETE_RESOURCES', function() {
       ...initialState,
       resourceType: 'hellos',
       resources: {
-        1: null,
         3: { id: 3 },
         4: { id: 4 },
-        13: null,
       },
       lists: {
         bookmarks: [2, 3],
@@ -252,10 +250,8 @@ describe('reducers: DELETE_RESOURCES', function() {
       ...initialState,
       resourceType: 'hellos',
       resources: {
-        1: null,
         3: { id: 3 },
         4: { id: 4 },
-        13: null,
       },
       lists: {
         bookmarks: [2, 3],
@@ -329,10 +325,8 @@ describe('reducers: DELETE_RESOURCES', function() {
       ...initialState,
       resourceType: 'hellos',
       resources: {
-        1: null,
         3: { id: 3 },
         4: { id: 4 },
-        13: null,
       },
       lists: {
         bookmarks: [2, 3],
@@ -405,10 +399,8 @@ describe('reducers: DELETE_RESOURCES', function() {
       ...initialState,
       resourceType: 'hellos',
       resources: {
-        1: null,
         3: { id: 3 },
         4: { id: 4 },
-        13: null,
       },
       meta: {
         1: {

diff --git a/packages/redux-resource/test/unit/reducers/delete.js b/packages/redux-resource/test/unit/reducers/delete.js
@@ -213,8 +213,6 @@ describe('reducers: delete', function() {
         resourceType: 'hellos',
         resources: {
           1: { id: 1 },
-          3: null,
-          4: null,
         },
         lists: {},
         requests: {},
@@ -275,9 +273,7 @@ describe('reducers: delete', function() {
       expect(reduced).to.deep.equal({
         resourceType: 'hellos',
         resources: {
-          0: null,
           3: { id: 3 },
-          4: null,
         },
         lists: {},
         requests: {},
@@ -347,8 +343,6 @@ describe('reducers: delete', function() {
         resourceType: 'hellos',
         resources: {
           1: { id: 1 },
-          3: null,
-          4: null,
         },
         lists: {},
         requests: {
@@ -430,8 +424,6 @@ describe('reducers: delete', function() {
         resourceType: 'hellos',
         resources: {
           1: { id: 1 },
-          3: null,
-          4: null,
         },
         lists: {},
         requests: {
@@ -514,8 +506,6 @@ describe('reducers: delete', function() {
         resourceType: 'hellos',
         resources: {
           1: { id: 1 },
-          3: null,
-          4: null,
         },
         lists: {},
         requests: {
@@ -597,8 +587,6 @@ describe('reducers: delete', function() {
         resourceType: 'hellos',
         resources: {
           1: { id: 1 },
-          3: null,
-          4: null,
         },
         lists: {},
         requests: {
@@ -679,8 +667,6 @@ describe('reducers: delete', function() {
         resourceType: 'hellos',
         resources: {
           1: { id: 1 },
-          3: null,
-          4: null,
         },
         lists: {},
         requests: {
@@ -759,8 +745,6 @@ describe('reducers: delete', function() {
         resourceType: 'hellos',
         resources: {
           1: { id: 1 },
-          3: null,
-          4: null,
         },
         lists: {},
         requests: {
@@ -830,8 +814,6 @@ describe('reducers: delete', function() {
         resourceType: 'hellos',
         resources: {
           1: { id: 1 },
-          3: null,
-          4: null,
         },
         lists: {
           oink: [10],