Fix old issues detected by phpstan

jamesread · Aug 28, 2023 · 825900e · 825900e
1 parent 034222d
commit 825900e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/src/main/php/libAllure/ErrorHandler.php b/src/main/php/libAllure/ErrorHandler.php
@@ -203,6 +203,8 @@ public function handleHttpError($code)
             case '401':
                 $message = 'Unauthorized.';
                 break;
+            default:
+                $message = 'Unknown (' . $code . ')';
         }
 
         $this->render('HTTP Error', $message, $code);

diff --git a/src/main/php/libAllure/HtmlLinksCollection.php b/src/main/php/libAllure/HtmlLinksCollection.php
@@ -62,7 +62,7 @@ public function rewind(): void
         $this->iteratorPosition = 0;
     }
 
-    public function getChildCollection($linkTitle = null)
+    public function getChildCollection($title = null)
     {
         if (empty($title)) {
             $title = $this->collection[$this->iteratorPosition]['title'];

diff --git a/src/main/php/libAllure/Template.php b/src/main/php/libAllure/Template.php
@@ -177,14 +177,8 @@ public function display($template = null, $cacheId = null, $compileId = null, $p
         parent::display($template, $cacheId, $compileId);
 
         foreach ($this->autoClearVars as $varName) {
-            if (method_exists($this, 'get_template_vars')) {
-                if ($this->get_template_vars($varName)) {
-                    $this->clear_assign($varName);
-                }
-            } elseif (method_exists($this, 'tpl_vars')) {
-                if ($this->tpl_vars($varName)) {
-                    $this->clear_assign($varName);
-                }
+            if ($this->getTemplateVars($varName)) {
+                $this->clearAssign($varName);
             }
         }
     }