Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollup from parent isn't running #45

Closed
solo-1234 opened this issue Mar 3, 2021 · 7 comments
Closed

rollup from parent isn't running #45

solo-1234 opened this issue Mar 3, 2021 · 7 comments

Comments

@solo-1234
Copy link

I just set up a rollup from a parent trigger, and it's not running. Any idea why not?

I checked Is Rollup Started From Parent
and added Rollup.runFromTrigger(); to my class which runs when parents are inserted, as the line right after inserting the children.

Do I also need to tell it which child object to roll up? I'm reading through the readme but don't see anything about that when using the CMDT approach (only when using the invocable)

Thanks!

@solo-1234
Copy link
Author

I reinstalled and it's still not working :( now what?

@jamessimone
Copy link
Owner

@solo-1234 hmm, I will have to investigate further. Sorry for prematurely closing this!

@jamessimone jamessimone reopened this Mar 3, 2021
@solo-1234
Copy link
Author

np, thanks!

jamessimone added a commit that referenced this issue Mar 3, 2021
…relationship field names being present in queries
@jamessimone
Copy link
Owner

@solo-1234 please reinstall - you should be all set. This was due to a small difference in behavior between the invocable/trigger based code paths that has now been consolidated, sorry about that! Once you've confirmed that you have this working, I will close the issue.

@solo-1234
Copy link
Author

still not working :(

jamessimone added a commit that referenced this issue Mar 4, 2021
…erages could blow up when a null value was present, fixed a potential concat issue caused by trailing delimiters, added additional integration tests. Fixed an issue with usage of RollupFlowBulkProcessor where an inner exception could get inadvertently eaten
jamessimone added a commit that referenced this issue Mar 4, 2021
* Actual fix for #45 (support for custom objects), fixed issue where averages could blow up when a null value was present
* Fixed a potential concat issue caused by trailing delimiters, added additional integration tests. 
* Fixed an issue with usage of RollupFlowBulkProcessor where an inner exception could get inadvertently eaten
* Standardized how Rollup__mdt records are retrieved, fixing for good the issues present with custom fields/objects being used in Rollup__mdt entity definition and field definition fields - code review feedback from @jongpie
@jamessimone
Copy link
Owner

@solo-1234 #47 should address any lingering issues with the use of custom objects/custom fields - please let me know!

@solo-1234
Copy link
Author

Seems like it's working now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants