Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to select an existing CMDT record when recalculating #59

Closed
jongpie opened this issue Mar 18, 2021 · 5 comments · Fixed by #61
Closed

Add the ability to select an existing CMDT record when recalculating #59

jongpie opened this issue Mar 18, 2021 · 5 comments · Fixed by #61

Comments

@jongpie
Copy link
Collaborator

jongpie commented Mar 18, 2021

The "Recalculate Rollup" component currently requires you to enter all of the rollup details. This works great with having full control - but if you've already defined a Rollup__mdt record with all of the details, it's a little repetitive to have to re-enter it. Ideally, this component should have 2 options to select from

  1. Manual Entry - the existing functionality. This is definitely nice to have, and it's required in order to do rollups for objects like task, event & user since they're not currently supported in CMDT EntityDefinition fields
  2. Select Existing Rollup - new functionality. When this option is used, the component should show a list of Rollup__mdt records (maybe displayed in a dropdown?) for the admin/user to select

In either scenario, I think you'd still want to be able to specify a WHERE clause, so the existing input "Where Clause SOQL Filters (Optional)" should be displayed for both options.

@jongpie
Copy link
Collaborator Author

jongpie commented Mar 19, 2021

Follow-up thought on this - I initially wrote that the list of Rollup__mdt records could maybe displayed in a dropdown, but what do you think about instead designing it so you can select & run multiple Rollup__mdt records at the same time? I think it would have to be limited to Rollup__mdt records with the same CalcItem__c, but it'd be handy to be able to select & recalculate several rollups all at once.

@jamessimone
Copy link
Owner

Yeah, I think that's a great idea. We can just group the Rollup__mdt records by CalcItem__c and return the list of those names - then it's as simple as selecting the option you want from a lightning-combobox element. I love it! Should be a fun one to work on.

@dhoechst
Copy link

Was just coming over to log this specific issue. I built 4 rollups from the same CalcItem__c and doing the initial rollup was kind of a pain to reenter them. In my case, I wanted the where clause to be the one specified in the Rollup__mdt records which was slightly different for each one.

@jamessimone
Copy link
Owner

@dhoechst excellent feedback to add into the mix. I’m planning to knock this one out this weekend!

jamessimone added a commit that referenced this issue Mar 29, 2021
…ings Introduced (#61)

* Fixes #59 by adding CMDT section to the Rollup recalculation application

* Fixes #58 by adding Rollup Settings hierarchy custom setting for granular user, profile, and org-wide rollup control - plus it will make installing/upgrading a whole lot easier

* @jongpie feedback (w h i t e s p a c e on the 'Id' field), added note in Readme about screen locking for full recalculation, added first jest unit test for rollupForceRecalculation LWC

* fixing Github Action

* Finishing initial round of jest testing for rollupForceRecalculation LWC

* Updating build script to be less strict if removing scratch org is the failure reason

* Last of @jongpie feedback - defaulting RollupSettings__c.IsEnabled__c to true
@jamessimone
Copy link
Owner

@dhoechst in the event that you need to use the full recalculation again, this is now released with #61 ! Thanks again for stopping by.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants