FIRST/LAST does not properly filter by lookup item (and potential issues with SOQL where clause) #80

jamessimone · 2021-04-19T19:32:44Z

Reported by Katherine West -

FIRST/LAST does not constrain the SOQL query by lookup item - easy fix
FIRST/LAST may not be correctly getting the SOQL where clause - still need to check on this one
delete operations on FIRST/LAST need to exclude current items
return human-readable error message if order by is not passed for first/last from flow
still run FIRST/LAST if current iteration's items get filtered out via the calc item where clause (since, like AVERAGE, FIRST and LAST are full recalcs every time)

…ade by rollup calculators, as well as fixing a bug with FIRST/LAST operations where the lookup clause was not being properly passed through

…ST/LAST * return human-readable error message when order by is not included from flow * correctly run rollup when calc item where clause would exclude the only items passed

* Initial refactor necessary to start supporting rollups all the way to ultimate parent for hierarchy/self-referential lookups like Account.ParentId * Fixes #80 by correctly passing calc item where clause to re-queries made by rollup calculators, as well as fixing a bug with FIRST/LAST operations where the lookup clause was not being properly passed through * Continued fixes for #80: * properly support delete operations for FIRST/LAST * return human-readable error message when order by is not included from flow * correctly run rollup when calc item where clause would exclude the only items passed * Finished wiring hierarchical rollups into the grandparent rollup framework * Additional consideration for #80 zero-based where clause filtering

…ate lookup items if the current value would be excluded due to the calc item where clause, but the old item's value would not be excluded.

jamessimone added a commit that referenced this issue Apr 19, 2021

Fixes #80 by correctly passing calc item where clause to re-queries m…

f12f3e1

…ade by rollup calculators, as well as fixing a bug with FIRST/LAST operations where the lookup clause was not being properly passed through

jamessimone added a commit that referenced this issue Apr 21, 2021

Additional consideration for #80 zero-based where clause filtering

868510b

jamessimone mentioned this issue Apr 21, 2021

V1.2.10 - Hierarchy Rollups & FIRST/LAST bugfixes #81

Merged

jamessimone closed this as completed in #81 Apr 21, 2021

jamessimone added a commit that referenced this issue Apr 22, 2021

Further fixes for #80 reported by Katherine West - rollups should upd…

5689bf8

…ate lookup items if the current value would be excluded due to the calc item where clause, but the old item's value would not be excluded.

jamessimone mentioned this issue May 6, 2021

WhereFieldEvaluator too permissive on updates #95

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FIRST/LAST does not properly filter by lookup item (and potential issues with SOQL where clause) #80

FIRST/LAST does not properly filter by lookup item (and potential issues with SOQL where clause) #80

jamessimone commented Apr 19, 2021 •

edited

FIRST/LAST does not properly filter by lookup item (and potential issues with SOQL where clause) #80

FIRST/LAST does not properly filter by lookup item (and potential issues with SOQL where clause) #80

Comments

jamessimone commented Apr 19, 2021 • edited

jamessimone commented Apr 19, 2021 •

edited