Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for reparented records #28

Merged
merged 19 commits into from Feb 18, 2021

Conversation

jongpie
Copy link
Collaborator

@jongpie jongpie commented Feb 18, 2021

Closes #7 - Added support for reparenting records, plus changes from @jamessimone for Spring '21 updates

@jongpie jongpie temporarily deployed to Test February 18, 2021 02:41 Inactive
@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #28 (797824d) into master (e113744) will decrease coverage by 0.70%.
The diff coverage is 77.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   92.40%   91.70%   -0.71%     
==========================================
  Files           3        3              
  Lines        1382     1458      +76     
==========================================
+ Hits         1277     1337      +60     
- Misses        105      121      +16     
Flag Coverage Δ
Apex 91.70% <77.51%> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rollup/main/default/classes/Rollup.cls 91.53% <77.34%> (-0.89%) ⬇️
rollup/main/default/classes/RollupEvaluator.cls 91.91% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e113744...797824d. Read the comment docs.

Copy link
Owner

@jamessimone jamessimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice job man, I know it's a lot to take on a 3000+ line codebase and just run with it.

@jongpie jongpie merged commit b6244d2 into master Feb 18, 2021
@jongpie jongpie deleted the feature/support-for-reparented-records branch February 18, 2021 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for reparenting
2 participants