Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CMDT table in Recalculate Rollup lwc #78

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Conversation

jongpie
Copy link
Collaborator

@jongpie jongpie commented Apr 15, 2021

Closed #62 by adding a read-only datatable that shows the list of CMDT records (based on the selected CalcItem__c)

image

@jamessimone jamessimone temporarily deployed to Test April 15, 2021 23:43 Inactive
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

❗ No coverage uploaded for pull request base (v1.2.9@63cdb06). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             v1.2.9      #78   +/-   ##
=========================================
  Coverage          ?   96.96%           
=========================================
  Files             ?        8           
  Lines             ?     2535           
  Branches          ?        0           
=========================================
  Hits              ?     2458           
  Misses            ?       77           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63cdb06...2fa4400. Read the comment docs.

@jongpie jongpie temporarily deployed to Test April 15, 2021 23:47 Inactive
@jamessimone jamessimone self-requested a review April 15, 2021 23:49
Copy link
Owner

@jamessimone jamessimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nicely done, thanks for pitching in on this one 👌

@jongpie jongpie merged commit fc02ba5 into v1.2.9 Apr 15, 2021
jamessimone added a commit that referenced this pull request Apr 16, 2021
* Fixed bug with polymorphic fields being used in where clauses when rollup is started from parent - found while migrating the rest of Rollup tests away from Opportunity object as part of the definitive fix for #74

* Fix for #75 - revert named export from RollupForceRecalculation LWC, as this breaks the current version of Locker's event handling

* Added CMDT table in Recalculate Rollup lwc (#78)

* Fixes #77 by updating example rollup action picture to correctly represent the options available

* Update README with consistent 'buttons'

* Final fixes for #79 to remove all tests with DML on opportunity

* Added version description and release notes url to sfdx-project.json

* Remove UPSERT from invocable descriptions

* Fix some more polymorphic where clause edge cases

* Tweaking build script to ensure tests get run even when scratch org allotment is over limit / does not exist

Co-authored-by: Jonathan Gillespie <jonathan.c.gillespie@gmail.com>
@jamessimone jamessimone deleted the feature/lwc-cmdt-table branch April 16, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants