add coverage-api build target. Only runs high level tests.

Should help expose unnecessary code.
jamestalmage · Dec 19, 2014 · 9b3b2bb · 9b3b2bb
1 parent 9ce6b75
commit 9b3b2bb
Show file tree

Hide file tree

Showing 5 changed files with 36 additions and 35 deletions.
diff --git a/gulpfile.js b/gulpfile.js
@@ -2,43 +2,44 @@ var gulp = require('gulp');
 var gutil = require('gulp-util');
 var mocha = require('gulp-mocha');
 var istanbul = require('gulp-istanbul');
+var _ = require('lodash');
 
 gulp.task('mocha',mochaTask);
-gulp.task('coverage',coverageTask);
+gulp.task('coverage',coverage());
+gulp.task('coverage-api',coverage({grep:'@api'}));
 
 gulp.task('watch-mocha',function(){
   gulp.watch(['test/**','src/**'],['mocha']);
   mochaTask();
 });
 
-gulp.task('watch-coverage',function(){
-  gulp.watch(['test/**','src/**'],['coverage']);
-  coverageTask();
-});
-
 gulp.task('example',function(){
   require('./examples/examples')();
 });
 
-function coverageTask(cb){
-  gulp.src(['src/*.js'])
-    .pipe(istanbul()) // Covering files
-    .pipe(istanbul.hookRequire()) // Force `require` to return covered files
-    .on('error', logMochaError)
-    .on('finish', function () {
-      var opts = process.env.TRAVIS ? {} : {grep:'original-cli-table', invert:true};
-
-      gulp.src(['test/*.js'])
-        .pipe(mocha(opts))
-        .on('error',function(err){
-          logMochaError(err);
-          if(cb) cb(err);
-        })
-        .pipe(istanbul.writeReports()) // Creating the reports after tests run
-        .on('end', function(){
-          if(cb) cb();
-        });
-    });
+function coverage(opts){
+  opts = opts || {};
+
+  function coverageTask(cb){
+    gulp.src(['src/*.js'])
+      .pipe(istanbul()) // Covering files
+      .pipe(istanbul.hookRequire()) // Force `require` to return covered files
+      .on('error', logMochaError)
+      .on('finish', function () {
+        gulp.src(['test/*.js'])
+          .pipe(mocha(opts))
+          .on('error',function(err){
+            logMochaError(err);
+            if(cb) cb(err);
+          })
+          .pipe(istanbul.writeReports()) // Creating the reports after tests run
+          .on('end', function(){
+            if(cb) cb();
+          });
+      });
+  }
+
+  return coverageTask;
 }
 
 function mochaTask(){

diff --git a/test/original-cli-table-index-tests.js b/test/original-cli-table-index-tests.js
@@ -1,4 +1,4 @@
-describe('original-cli-table index tests',function(){
+describe('@api original-cli-table index tests',function(){
   var Table = require('../src/table');
   var chai = require('chai');
   var expect = chai.expect;

diff --git a/test/original-cli-table-newlines-test.js b/test/original-cli-table-newlines-test.js
@@ -1,4 +1,4 @@
-describe('original-cli-table newline tests',function(){
+describe('@api original-cli-table newline tests',function(){
   var Table = require('../src/table');
   var chai = require('chai');
   var expect = chai.expect;

diff --git a/test/table-test.js b/test/table-test.js
@@ -1,4 +1,4 @@
-describe('Table', function () {
+describe('@api Table', function () {
   var Table = require('../src/table');
   var chai = require('chai');
   var expect = chai.expect;
@@ -52,14 +52,14 @@ describe('Table', function () {
     var table = new Table({style:{head:[],border:[]}});
 
     table.push(
-      [{rowSpan:2,content:'greetings'},{rowSpan:2,content:'greetings'},'hello'],
+      [{rowSpan:2,content:'greetings'},{rowSpan:2,content:'greetings',vAlign:'center'},'hello'],
       ['howdy']
     );
 
     var expected = [
         '┌───────────┬───────────┬───────┐'
-      , '│ greetings │ greetings │ hello │'
-      , '│           │           ├───────┤'
+      , '│ greetings │           │ hello │'
+      , '│           │ greetings ├───────┤'
       , '│           │           │ howdy │'
       , '└───────────┴───────────┴───────┘'
     ];
@@ -71,15 +71,15 @@ describe('Table', function () {
     var table = new Table({style:{head:[],border:[]}});
 
     table.push(
-      ['hello',{rowSpan:2,content:'greetings'},{rowSpan:2,content:'greetings'}],
+      ['hello',{rowSpan:2,content:'greetings'},{rowSpan:2,content:'greetings',vAlign:'bottom'}],
       ['howdy']
     );
 
     var expected = [
         '┌───────┬───────────┬───────────┐'
-      , '│ hello │ greetings │ greetings │'
+      , '│ hello │ greetings │           │'
       , '├───────┤           │           │'
-      , '│ howdy │           │           │'
+      , '│ howdy │           │ greetings │'
       , '└───────┴───────────┴───────────┘'
     ];
 

diff --git a/test/verify-legacy-compatibility-test.js b/test/verify-legacy-compatibility-test.js
@@ -3,7 +3,7 @@
      commonTests(require('cli-table'));
   });
 
-  describe('cli-table2 matches verified behavior',function(){
+  describe('@api cli-table2 matches verified behavior',function(){
      commonTests(require('../src/table'));
   });