Updated support for more recent versions of Python and Django #60
Conversation
Changes were based on the following: - "honeypot" had to be replaced by module's actual name - a multiline condition with a line break before a binary operator triggers flake8's W503; changing that line would trigger another error or warning, or more require more changes elsewhere
- removed parts related to testing multiple DB that didn't work - updated test matrices based on currently supported releases - simplified GitHub action by relying more on tox - added a separate job for linter
- forgot to add Python 3.12 to GitHub Actions in previous commit - the long deprecated method assertEquals of unittest.TestCase was removed with the release of Python 3.12; had to be replaced
|
I've made all the changes that were planned so far. I also made a temporary repository to freely test the new GitHub Action workflow, so everything should work. |
|
Thank you, I'll take a closer look at this soon. The one change I'll likely make is to eliminate some of the intermediate versions of Python to save time/compute on test runs. (i.e. only test on Python 3.8 and 3.12 in CI) Thanks so much for taking the time to update this! |
|
It's my pleasure. I've been using this package for a long time, so when I saw the opportunity to contribute in some way, I felt like it was the right thing to do.
Yes, it's a bit ridiculous right now, but support for Django 4.1 has just ended (December 1, 2023), so it can be removed from the test matrix, and support for Django 3.2 will end April 2024. [1] That should make things more manageable. |
This is currently still a work in progress, as discussed in #59. Do not merge yet!
I've updated tox and the GitHub action to support more recent versions of Python and Django.
What is currently still planned:
Because services (like postgresql) are not supported yet by act, I'll have to rely more on commits to test GHA workflows from now on.