Remove Turbo from Dashboard #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we can determine what is relying on Turbo under the hood easily.
As we no longer need to use it since we're doing full page loads when navigating between tabs.
Adds a next button, rather than auto-submitting the form to let it be powered by just htmx. Auto submit can likely be done with htmx or hyperscript, but I do not want it to become a blocker.
As a full page reload is fine.
Because 303 is Turbo specific and 302 is standard http
jamesvandyne
force-pushed
the
admin-no-turbo
branch
from
21f3028
to
a9b2336
Compare
With some HTMX and Hyperscript
With some HTMX and Hyperscript
jamesvandyne
force-pushed
the
admin-no-turbo
branch
from
6484b0e
to
b928d76
Compare
Really this should be a commit per change and broken up into a lot of smaller commits...but I was doing a lot of experimenting figuring out how to implement this during development.
jamesvandyne
force-pushed
the
admin-no-turbo
branch
from
b928d76
to
c83744d
Compare
Because turbo is no longer installed / enabled, there's no need disable it or set target frames.
As it's no longer used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes Turbo from the Tanzawa dashboard. HTMX is better supported amongst Django projects and this aims to simplify how the admin works so it's more maintainable.
While removing Turbo, I was able able to remove a few different Stimulus controllers as well. Functionally with this PR, there should be no breaking changes. However, as the File picker modal has moved to using the common modal in the dashboard, it's now narrower than before and could use some refinements in the design. That has been left out of this PR.