Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWFloatMax & JWIntegerMax wrong operation #2

Closed
S4Hyry opened this issue Nov 16, 2023 · 1 comment
Closed

JWFloatMax & JWIntegerMax wrong operation #2

S4Hyry opened this issue Nov 16, 2023 · 1 comment

Comments

@S4Hyry
Copy link

S4Hyry commented Nov 16, 2023

Instead of Max, the node JWIntegerMax and JWFloatMax are doing min :

comfyui_primitive_ops.py
@generate_functional_node("jamesWalker55", "JWIntegerMax", "Integer Maximum") def _(a: int = 0, b: int = 0) -> tuple[int]: return (min(a, b),)

@generate_functional_node("jamesWalker55", "JWFloatMax", "Float Maximum") def _(a: float = 0, b: float = 0) -> tuple[float]: return (min(a, b),)

@jamesWalker55
Copy link
Owner

Thanks, can't believe I missed that! I've just pushed a fix to the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants