Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated requirements.txt #44

Merged
merged 7 commits into from
Oct 12, 2023
Merged

Updated requirements.txt #44

merged 7 commits into from
Oct 12, 2023

Conversation

ropelletier
Copy link
Contributor

Changed to this file with versions that will solve #42 and #43

@ball42 ball42 self-requested a review October 12, 2023 14:05
README.md Show resolved Hide resolved
Copy link
Collaborator

@ball42 ball42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New requirements.txt tested OK in v3.0.3 and the version of v3.1.0 available in the develop branch.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going ahead and fixing this! The new requirements.txt file worked for installing stable dependencies within a JAWA venv in testing. The code has been adjusted in the upcoming release v3.1.0 to avoid this error and also provide compatibility with Flask 3.0.0. However, it's still very wise to include the tested versions for packages/libraries within the requirements.txt, so this convention will be adopted moving forward and will include the other listed items in requirements.txt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants