Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose DataBase.xml jdbcParameters as environment variable #25

Closed
justin-watkinson-electric opened this issue Jun 22, 2023 · 1 comment · Fixed by #26
Closed

Expose DataBase.xml jdbcParameters as environment variable #25

justin-watkinson-electric opened this issue Jun 22, 2023 · 1 comment · Fixed by #26

Comments

@justin-watkinson-electric

Is your feature request related to a problem? Please describe.
When configuring JAMF Pro with Amazon Aurora, we learned that the default connection string in the DataBase.xml needed to be modified.

Describe the solution you'd like
I'd like to update this section of the configuration.sh file to also include an environment variable override for the jdbcParameters XML field.

Describe alternatives you've considered
Given that the ROOT.war is still compressed at bootstrap, I didn't see many non-invasive alternatives that didn't involve modifying the docker image posted to Docker hub.

@battlecow
Copy link
Contributor

Thanks for the request, this should be completed in #26. Added both the ability to override via ENV as requested, but also as an entire DataBase.xml file mounted to /config in case the interpolation gets weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants