add: separate advertise from listen address #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
team-adder
bot
requested review from
deynekas,
jizi,
jojand,
jsfpdn,
juldou,
kasparjarek,
martinvizvary and
mrackoa
team-adder
bot
requested review from
Tantalor93,
mrackoa and
tsvoboda-wandera
github-actions
bot
added
code
jojand
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
goremanor similar tool.Motivation and Context
The previous version of Regatta introduced the Memberlist API, that API is consumed by clients to locate the cluster nodes. That means the addresses presented must be the addresses of the node which could be reached by the client. On the other hand, in certain situations it is advantageous to listen on e.g. all local interfaces. Separating the config for advertise and listen address allows for that use-case.
How Has This Been Tested?