add: improve server error reporting #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
code
coufalja
force-pushed
the
feature/server_errors
branch
2 times, most recently
from
875ac6c
to
c5d8fed
Compare
team-adder
bot
requested review from
deynekas,
jizi,
jojand,
jsfpdn,
juldou,
kasparjarek,
martinvizvary,
mrackoa,
Tantalor93 and
tsvoboda-wandera
coufalja
force-pushed
the
feature/server_errors
branch
from
813c675
to
1c697a0
Compare
coufalja
force-pushed
the
feature/server_errors
branch
from
1c697a0
to
3055c9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use proper GRPC codes for various API error responses.
Motivation and Context
To be able to distinguish the errors which are safe to retry on and which are not client side.
How Has This Been Tested?
UTs, ITs