Internalise Raft lib #292
Merged
Internalise Raft lib #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coufalja
force-pushed
the
feature/internalise_raft
branch
2 times, most recently
from
5974c2a
to
6136acc
Compare
coufalja
force-pushed
the
feature/internalise_raft
branch
2 times, most recently
from
0cdbeca
to
6f3d884
Compare
coufalja
force-pushed
the
feature/internalise_raft
branch
from
6f3d884
to
07ea2a5
Compare
team-adder
bot
requested review from
deynekas,
jizi,
jojand,
jsfpdn,
kasparjarek and
martinvizvary
jsfpdn
reviewed
Jun 3, 2024
tsvoboda-wandera
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Raft replacement targets next major 0.6.x release, but for now will live out-of-main branch in feat/raft-replacement due to need of extensive testing.
The PR is a
Related Issue
Related to https://github.com/jamf/regatta/blob/master/docs/proposals/003-replace-raft-lib.md
Motivation and Context
This PR forks the dragonboat lib into the Regatta codebase. The goal of the change is to get rid of hacks in Regatta codebase as well as ensure the ongoing development. Dragonboat is now in sort of a development limbo as well as being encumbered by historic burden. The fork should give us more freedom in designing and maintaining regatta as well as potentially ease up replacement with a different library.
How Has This Been Tested?