Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CORS Requests #18

Merged
merged 3 commits into from
Nov 1, 2015
Merged

Allow CORS Requests #18

merged 3 commits into from
Nov 1, 2015

Conversation

toehio
Copy link
Contributor

@toehio toehio commented Nov 1, 2015

This is a simple solution to allow all CORS requests, which are necessary when using s3rver for testing web applications. I tested it with Chromium.

@jamhall
Copy link
Owner

jamhall commented Nov 1, 2015

@toehio Hello. It would be nice if CORs is activated via an option - it should be disactivated by default. What do you think?

@toehio
Copy link
Contributor Author

toehio commented Nov 1, 2015

That's a good idea. I just added the option.

jamhall added a commit that referenced this pull request Nov 1, 2015
@jamhall jamhall merged commit 3f5b091 into jamhall:master Nov 1, 2015
@jamhall
Copy link
Owner

jamhall commented Nov 1, 2015

Excellent! Thanks very much. I'll push a new release to NPM tomorrow morning 👍

@jamhall
Copy link
Owner

jamhall commented Nov 2, 2015

@toehio - v.0.0.10 has been released. It has also been pushed to NPM. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants