Cancel biometric login overlay if authenticator is not in foreground

[ghost]

Apps using the biometric login overlay generally dismiss the overlay if the app is switched/closed.

When switching/closing Authenticator, the biometric login overlay stays in the foreground until the user taps the dead space above the biometric login request.
This makes for an awkward action when cancelling the process in comparison to what apps usually do.

[jamie-mh]

In my testing, the overlay is always cancelled when pressing the home button or switching apps.
What device are you using? It might be a bug specific the implementation of Android you are running.

[ghost]

OnePlus 6
LineageOS 17.1 (Android 10)

[Schokobecher]

I can replicate that behavior with MIUI 12 (Android 11)

After using the on-screen task switcher key

Pressing the on-screen home key

[jamie-mh]

I've made a change that may or may not have fixed the issue. Essentially, it should cancel the prompt when the app loses focus.
It will be available in the next release. I going to keep this issue open until I can confirm that it has been fixed.

[ghost]

If you push a test release too me, I'd be happy to confirm prior to the official release.

[jamie-mh]

Sure, that would be great. Here's a build from the latest commit:

me.jmh.authenticatorpro-arm64-v8a.apk.zip

[ghost]

Sure, that would be great. Here's a build from the latest commit:

me.jmh.authenticatorpro-arm64-v8a.apk.zip

Appears to work for me.
@Schokobecher, does this fix it for you?

[Schokobecher]

Just tried it, sadly it did not work.

• Open the App
• Instead of Unlocking hit Recents
  
• Instead of Unlocking hit Home
  

Pressing above the Fingerprint section closes the app with the messageAuthentication canceled
Pressing Back closes the app with the same message

I can switch between Recents, Home and the app using the on-screen keys without the authentication prompt disappearing

[jamie-mh]

Thanks for testing it. This might be a bug in a version of a library used. Android issue 149770989. I will look into it further.

[ghost]

If it helps, Magisk Manager is open source on GH, and the auth functions as you'd expect it to.

[jamie-mh]

After checking the source of Magisk Manager, it doesn't seem to be doing anything different other than it doesn't allow device credentials (pin). This might have something to do with it as mentioned in the above issue. I will run some tests with the latest version of the biometrics library once it's released.

[jamie-mh]

1.14 no longer uses setDeviceCredentialAllowed(true), so this problem might be solved. If the Android bug report is accurate that is.

[ghost]

Can confirm the issue no longer exists in 1.13.1. From: jmh <notifications@github.com> Date: Saturday, 23 January 2021 at 3:23 am To: jamie-mh/AuthenticatorPro <AuthenticatorPro@noreply.github.com> Cc: jslawler <jslawler@outlook.com>, Author <author@noreply.github.com> Subject: Re: [jamie-mh/AuthenticatorPro] Cancel biometric login overlay if authenticator is not in foreground (#69) 1.14 no longer uses setDeviceCredentialAllowed(true), so this problem might be solved. If the Android bug report is accurate that is. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#69 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABN2DKI4KB7RS4WCPHEARUTS3GX77ANCNFSM4U3OKP6Q>.

[Schokobecher]

Works for me, too. It's a bit awkward as the overlay lingers for half a second or so before disapperaing

[jamie-mh]

Thanks, the delay seems like normal Android behaviour, not much I can do about that. Case closed.