Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making icons the same style #35

Closed
luaxlab opened this issue Jul 12, 2020 · 4 comments
Closed

Making icons the same style #35

luaxlab opened this issue Jul 12, 2020 · 4 comments

Comments

@luaxlab
Copy link
Contributor

luaxlab commented Jul 12, 2020

Hello,

I've noticed that the icons dont quite match eatch other.
Most icons have got no frame, tough some icons, e.g. Nextcloud, Snapchat and Nintendo got one.

I'd recommend adding rounded corners, some icons (e.g. Nintendo, Nexcloud) have got to many details, I'd replace them completely. (Even on my Galaxy A71 they dont quite look good)

If someone agrees with me.... I could "do the work".

Have a great day.

@luaxlab luaxlab changed the title Making Icons the same style Making icons the same style Jul 12, 2020
@jamie-mh
Copy link
Owner

Hi @luaxlab ,

Are you proposing adding rounded corners to all the icons or just the ones with frames?
For many of these icons it wouldn't be too difficult to just remove frame around them.

@luaxlab
Copy link
Contributor Author

luaxlab commented Jul 13, 2020

Hi @jamie-mh,

Only the ones with frames. Of course removing the frame completely would be the better choice, just haven't tought about that.
For some (overdetailed) icons, I'd suggest replacing them tough.

@jamie-mh
Copy link
Owner

Indeed, that is preferable. The Nextcloud icon for instance can be replaced with just the blue image (https://upload.wikimedia.org/wikipedia/commons/6/60/Nextcloud_Logo.svg) without the text. That would probably look better.
Some icons such as Facebook and LinkedIn have a frame as part of the design, so removing that might not work.

@luaxlab
Copy link
Contributor Author

luaxlab commented Jul 13, 2020

I'll do that, I'll commit when I'm done.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants