Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix plugin errors #10

Merged
merged 3 commits into from
Jan 19, 2016
Merged

Fix plugin errors #10

merged 3 commits into from
Jan 19, 2016

Conversation

novemberborn
Copy link
Contributor

Fixes #9.

I threw in a code coverage tool as well. With the new tests commented out:

-----------|----------|----------|----------|----------|----------------|
File       |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
-----------|----------|----------|----------|----------|----------------|
 src/      |    82.76 |    77.27 |      100 |    80.77 |                |
  index.js |    82.76 |    77.27 |      100 |    80.77 | 42,43,75,90,95 |
-----------|----------|----------|----------|----------|----------------|
All files  |    82.76 |    77.27 |      100 |    80.77 |                |
-----------|----------|----------|----------|----------|----------------|

Final result:

-----------|----------|----------|----------|----------|----------------|
File       |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
-----------|----------|----------|----------|----------|----------------|
 src/      |      100 |    95.45 |      100 |      100 |                |
  index.js |      100 |    95.45 |      100 |      100 |                |
-----------|----------|----------|----------|----------|----------------|
All files  |      100 |    95.45 |      100 |      100 |                |
-----------|----------|----------|----------|----------|----------------|

The tests don't cover || 'handlebars' bit since resolveCwd('handlebars') already resolves it. I guess that's OK.

@novemberborn
fix test titles
f6865b5
@novemberborn
fix how plugin errors are thrown under Babel 6
2527f29 
* Upgrade usage of `this.errorWithNode()` calls
* Fix how the used import statement is derived
* Don't crash when `hbs` is called without any arguments
* Add tests
@novemberborn
add nyc for code coverage
2569f00
jamiebuilds added a commit that referenced this pull request Jan 19, 2016
@jamiebuilds
Merge pull request #10 from novemberborn/fix-plugin-errors
4042ca0 
Fix plugin errors
@jamiebuilds jamiebuilds merged commit 4042ca0 into jamiebuilds:master Jan 19, 2016
@jamiebuilds
Copy link
Owner

Thanks

@novemberborn novemberborn deleted the fix-plugin-errors branch January 19, 2016 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@novemberborn @jamiebuilds