Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: separate animation duration from transition duration #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SneakySensei
Copy link

@SneakySensei SneakySensei commented Sep 23, 2023

I was using this plugin and faced issues when using arbitrary values for duration-{value} because the utility collides with the inbuilt transition duration utility and throws this warning:

warn - The class `duration-[2s]` is ambiguous and matches multiple utilities.
warn - If this is content and not a class, replace it with `duration-[2s]` to silence this warning.

In this PR I've:

  • renamed the utility to animation-duration-{value}
  • made appropriate changes in the docs

Fixes #35
Fixes #38

@Hidde-Heijnen
Copy link

yeah, this definitely needs to be fixed, but maybe a cleaner solution is to just make tailwindcss-animate's duration work with arbitrary values? Or is that impossible?

@SneakySensei
Copy link
Author

yeah, this definitely needs to be fixed, but maybe a cleaner solution is to just make tailwindcss-animate's duration work with arbitrary values? Or is that impossible?

Yes that is impossible because tailwindcss doesn't allow the same util name for multiple distinct css properties as it would break the atomic nature of tailwind.

@hyoban
Copy link

hyoban commented Dec 4, 2023

How about animate-delay-xxx?

@SneakySensei
Copy link
Author

SneakySensei commented Dec 8, 2023

How about animate-delay-xxx?

I tried to keep this PR simple in order to get more inputs from @jamiebuilds. I could also open another PR to add animate-delay-{value} if this one goes through.

@ashoktamang
Copy link

This issue is still not fixed. What's blocking?

@Khoulaiz
Copy link

No offence please, but this is a red flag for me not to use this plugin.

@jamiebuilds
Copy link
Owner

Hi @Khoulaiz

No offence please, but this is a red flag for me not to use this plugin.

I do not care how it makes you feel, you do not pay me to maintain this plugin for you. Your response was not offensive, it was entitled. You are welcome to cry all you want about it in the comfort of your own home, but don't come to me with it, it's just annoying and it will not get me to help you.

If you would like to be less of an entitled jerk, you are welcome to fork any open source project you feel like, or even volunteer to help. You too can have the opportunity to listen to people whine in public about how you don't do enough for them for free.

Repository owner locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants