Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail with earlier versions of requests #89

Closed
jamielennox opened this issue Apr 28, 2019 · 0 comments · Fixed by #90
Closed

Tests fail with earlier versions of requests #89

jamielennox opened this issue Apr 28, 2019 · 0 comments · Fixed by #90
Milestone
1.6.0

Comments

@jamielennox
Copy link
Owner

There are a bunch of failing tests with requests < 2, mostly to do with cookie handling. There are also a bunch of failing tests with early versions of requests 2. We either need to bump the version requirement or add a contrib layer.

With requests 1 the library won't even load, so given i've not heard anything that should be safe to drop. Need to look into what the consequences of v2 are.
@jamielennox jamielennox added this to the 1.6.0 milestone Apr 28, 2019
@jamielennox jamielennox mentioned this issue Apr 28, 2019
Merged
jamielennox pushed a commit that referenced this issue Apr 28, 2019
Update minimum requests version to 2.3
4ea6d99 
There are a number of features and tests that don't pass with requests
versions older than 2.3. This version was released in May 2014, so I
think we should be safe by now.

Closes: #89
jamielennox pushed a commit that referenced this issue Apr 28, 2019
@jamielennox
Update minimum requests version to 2.3
3a7c98f 
There are a number of features and tests that don't pass with requests
versions older than 2.3. This version was released in May 2014, so I
think we should be safe by now.

Closes: #89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

Update minimum requests version to 2.3 jamielennox/requests-mock
1 participant
@jamielennox