Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"@latest" in npm-shrinkwrap.json skips shrinkpack #54

Closed
JamieMason opened this issue Jul 5, 2016 · 2 comments
Closed

"@latest" in npm-shrinkwrap.json skips shrinkpack #54

JamieMason opened this issue Jul 5, 2016 · 2 comments

Comments

@JamieMason
Copy link
Owner

Expected behaviour

npm install --loglevel http should report no network activity when installing a shrinkpacked project.

Actual behaviour

Network activity is reported in some circumstances (see below).

npm http request GET http://registry.npmjs.org/options
npm http 304 http://registry.npmjs.org/options

Steps to reproduce

Have a dependency in npm-shrinkwrap.json which has a from containing @latest such as;

"options": {
  "version": "0.0.6",
  "from": "options@latest",
  "resolved": "file:node_shrinkwrap/options-0.0.6.tgz"
}

Software versions used

OS         : osx mavericks 
node.js    : 6.2.2
npm        : 3.10.4
shrinkpack : 0.12.5
@JamieMason
Copy link
Owner Author

@latest seems to not be relevant after all, removing all "from" entries from npm-shrinkwrap.json has no effect.

"options": {
  "version": "0.0.6",
  "resolved": "file:node_shrinkwrap/options-0.0.6.tgz"
},

@JamieMason
Copy link
Owner Author

Unable to reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant