Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Personal notes on shows/Search with language/Grey out upcoming episodes #34

Closed
wants to merge 4 commits into from
Closed

Conversation

daniele-athome
Copy link
Contributor

  • A very rough implementation of a simple text area in show view for custom user notes.
  • Add a language=all parameter to GetSeries call and shows the language after the name in search result
  • Grey out upcoming episodes

Signed-off-by: Daniele Ricci daniele.athome@gmail.com

Signed-off-by: Daniele Ricci <daniele.athome@gmail.com>
Signed-off-by: Daniele Ricci <daniele.athome@gmail.com>
@daniele-athome daniele-athome changed the title Personal notes on shows Personal notes on shows/Search with language Mar 15, 2015
Signed-off-by: Daniele Ricci <daniele.athome@gmail.com>
Signed-off-by: Daniele Ricci <daniele.athome@gmail.com>
@daniele-athome daniele-athome changed the title Personal notes on shows/Search with language Personal notes on shows/Search with language/Grey out upcoming episodes Mar 16, 2015
@jamienicol
Copy link
Owner

Hi. Thanks for these, they're all good ideas and I'll be very happy to commit them! I'm a wee bit busy this week but I should get a chance to do a proper code review fairly soon. Sorry for keeping you waiting.

In the meantime, would it be possible to split these in to 3 different pull requests? And for the "notes" one, could you split all the database related stuff in to one commit, and the UI stuff into another?
For the notes UI, I think it might be a good idea to have the notes text box non-editable by default. And add a menu item to the toolbar to enter an edit mode. Let me know your thoughts on that (is it doable?)

Thanks!

@daniele-athome
Copy link
Contributor Author

Sorry for keeping you waiting.

No problem, I can use my own version on my device in the meantime ;-)

In the meantime, would it be possible to split these in to 3 different pull requests?

Sure, no problem. But I'll have to put them in 3 different branches to make it that way.

And for the "notes" one, could you split all the database related stuff in to one commit, and the UI stuff into another?

Will do.

For the notes UI, I think it might be a good idea to have the notes text box non-editable by default. And add a menu item to the toolbar to enter an edit mode. Let me know your thoughts on that (is it doable?)

That's a great idea. I actually hate that as soon as I click on the EditText the keyboard pops up.
Also, I would like to Linkify the text, so I can put URLs in it (e.g. my favourite streaming site for that series). What do you think?

Thanks!

Thank you for this great app!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants